src: use existing strings over creating new ones #14587
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a very very minor change.
nodejs-github-bot
added
c++
TimothyGu
approved these changes
Aug 2, 2017
jasnell
approved these changes
Aug 2, 2017
|
LGTM if CI is ok with it: https://ci.nodejs.org/job/node-test-pull-request/9446/ |
cjihrig
approved these changes
Aug 2, 2017
|
CI seems to hiccup, new attempt: https://ci.nodejs.org/job/node-test-pull-request/9449/ |
tniessen
reviewed
Aug 2, 2017
| @@ -77,13 +77,9 @@ void TCPWrap::Initialize(Local<Object> target, | |||
| // Init properties | |||
| t->InstanceTemplate()->Set(String::NewFromUtf8(env->isolate(), "reading"), | |||
There was a problem hiding this comment.
Any reason not to add "reading" to env.h as well? Are we trying to keep that list small?
There was a problem hiding this comment.
It’s there for strings that would otherwise be re-created multiple times in the lifetime of a Node instance, but this appears to be the only usage of it in src/.
tniessen
approved these changes
Aug 2, 2017
addaleax
added a commit
that referenced
this pull request
Aug 7, 2017
This is a very very minor change. PR-URL: #14587 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Aug 7, 2017
PR-URL: #14587 Reviewed-By: Anna Henningsen <[email protected]>
addaleax
added a commit
that referenced
this pull request
Aug 7, 2017
This is a very very minor change. PR-URL: #14587 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Aug 7, 2017
PR-URL: #14587 Reviewed-By: Anna Henningsen <[email protected]>
|
Should this be backported to |
MylesBorins
pushed a commit
that referenced
this pull request
Aug 16, 2017
This is a very very minor change. PR-URL: #14587 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Aug 16, 2017
This is a very very minor change. PR-URL: #14587 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 3, 2017
This is a very very minor change. PR-URL: #14587 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 5, 2017
This is a very very minor change. PR-URL: #14587 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
This was referenced Sep 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very very minor change.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src/tcp_wrap.cc